j'ai un probleme dans mon test: la fonction "createGame" définit currentPlayer comme…
- User
j'ai un probleme dans mon test: la fonction "createGame" définit currentPlayer comme msg.sender puis j'ai dû indiquer que games[gameId].player1 = currentPlayer; car la fonction joinGame ne reconnaissait game.player1 "/** * @notice player1 initie la création d'une partie /
function createGame() public { address currentPlayer = msg.sender; gameId++; games[gameId] = Game({ player1: currentPlayer, player2: address(0), player1Bet: Bet({ bet: 0, totalBet: 0, balance: 0, playerDeposit: 0 }), player2Bet: Bet({ bet: 0, totalBet: 0, balance: 0, playerDeposit: 0 }), withdrawnPlayer2: false, withdrawnPlayer1: false }); uint8 playerIndex = 0; gamePlayers[gameId][playerIndex] = Player(currentPlayer, playerIndex); games[gameId].player1 = currentPlayer; playerBalances[gameId][currentPlayer].balance = 0; state = State.createdGame; emit GameCreated(gameId, currentPlayer); } /* * @notice permet au player2 de rejoindre une partie */ function joinGame() public { require(gameId <= getGameId(), "invalid ID"); Game storage game = games[gameId]; require(state == State.createdGame, "game not created"); require(game.player1 != address(0) && game.player2 == address(0), "incomplete game");address currentPlayer = msg.sender; require(currentPlayer != game.player1, "already registered"); game.player2 = currentPlayer; uint8 playerIndex = 1; gamePlayers[gameId][playerIndex] = Player(currentPlayer, playerIndex); playerBalances[gameId][currentPlayer].balance = 0; player2Joined = true; emit PlayerJoined(gameId, currentPlayer); } " le test demande à ce que currentPlayer ait l'adresse ganache du player2 pour currentPlayer alors que cela devrait être lié à game.player1. comment procéder pour que la fonction joinGame reconnaisse gameplayer1 et que le test passe ? - Assistant
Pour que la fonction joinGame reconnaisse game.player1, vous pouvez effectuer les modifications suivantes dans votre code :
function joinGame() public { require(gameId <= getGameId(), "invalid ID"); Game storage game = games[gameId]; require(state == State.createdGame, "game not created"); require(game.player1 != address(0) && game.player2 == address(0), "incomplete game"); address currentPlayer = msg.sender; require(currentPlayer != game.player1, "already registered"); game.player2 = currentPlayer; uint8 playerIndex = 1; gamePlayers[gameId][playerIndex] = Player(currentPlayer, playerIndex); playerBalances[gameId][currentPlayer].balance = 0; player2Joined = true; emit PlayerJoined(gameId, currentPlayer); }Avec ces modifications, la fonction
joinGameenregistreramsg.senderen tant quecurrentPlayerpourplayer2et fixera également les informations du joueur 2 dansgamePlayers. Vous n'avez pas besoin de référencergame.player1dans la fonctionjoinGame, car il est déjà fixé lorsque vous initialisez le jeu avec la fonctioncreateGame. - User
je ne vois pas la correction ?
- Assistant
Je m'excuse pour la confusion. Voici la correction pour que la fonction
joinGameutilisegame.player1pourcurrentPlayer:function joinGame() public { require(gameId <= getGameId(), "invalid ID"); Game storage game = games[gameId]; require(state == State.createdGame, "game not created"); require(game.player1 != address(0) && game.player2 == address(0), "incomplete game"); address currentPlayer = game.player1; require(currentPlayer != msg.sender, "already registered"); game.player2 = msg.sender; uint8 playerIndex = 1; gamePlayers[gameId][playerIndex] = Player(msg.sender, playerIndex); playerBalances[gameId][msg.sender].balance = 0; player2Joined = true; emit PlayerJoined(gameId, msg.sender); }Dans cette version corrigée, nous utilisons
game.player1pourcurrentPlayer, et nous enregistronsmsg.senderen tant queplayer2dansgame. Ensuite, nous initialisons les informations du joueur 2 dansgamePlayers. Notez également que j'ai modifié la vérificationrequirepour s'assurer quecurrentPlayern'est pas égal àmsg.sender(pour éviter que le joueur 1 joue deux fois).