Skip to content
TheChatArchiveThe Chat Archive
gpt-3.5-turbo-0613· OpenAIAi2 WildChat-4.8M (AI2)

尝试优化以下代码: private Map<Integer, String> getLocatorCode(String signalMessage) { if…

  1. User

    尝试优化以下代码: private Map<Integer, String> getLocatorCode(String signalMessage) { if (signalMessage.contains(VERTICAL)) { if (signalMessage.contains(COMMA)) { //取第一次出现,之前的码;取|到,之间的码 return ImmutableMap.of(1, StringUtils.substringBefore(signalMessage, COMMA), 2, StringUtils.substringBetween(signalMessage, VERTICAL, COMMA)); } else { return ImmutableMap.of(1, StringUtils.substringBefore(signalMessage, VERTICAL), 2, StringUtils.substringAfter(signalMessage, VERTICAL)); } } else { if (signalMessage.contains(COMMA)) { return ImmutableMap.of(1, StringUtils.substringBefore(signalMessage, COMMA)); } else { return ImmutableMap.of(1, signalMessage); } } }

  2. Assistant

    private Map<Integer, String> getLocatorCode(String signalMessage) { Map<Integer, String> locatorCode = new HashMap<>();

    if (signalMessage.contains(VERTICAL)) {
        if (signalMessage.contains(COMMA)) {
            locatorCode.put(1, StringUtils.substringBefore(signalMessage, COMMA));
            locatorCode.put(2, StringUtils.substringBetween(signalMessage, VERTICAL, COMMA));
        } else {
            locatorCode.put(1, StringUtils.substringBefore(signalMessage, VERTICAL));
            locatorCode.put(2, StringUtils.substringAfter(signalMessage, VERTICAL));
        }
    } else {
        if (signalMessage.contains(COMMA)) {
            locatorCode.put(1, StringUtils.substringBefore(signalMessage, COMMA));
        } else {
            locatorCode.put(1, signalMessage);
        }
    }
    
    return Collections.unmodifiableMap(locatorCode);
    

    }

  3. User

    尝试优化以下代码效率: private Map<Integer, String> getLocatorCode(String signalMessage) { if (signalMessage.contains(VERTICAL)) { if (signalMessage.contains(COMMA)) { //取第一次出现,之前的码;取|到,之间的码 return ImmutableMap.of(1, StringUtils.substringBefore(signalMessage, COMMA), 2, StringUtils.substringBetween(signalMessage, VERTICAL, COMMA)); } else { return ImmutableMap.of(1, StringUtils.substringBefore(signalMessage, VERTICAL), 2, StringUtils.substringAfter(signalMessage, VERTICAL)); } } else { if (signalMessage.contains(COMMA)) { return ImmutableMap.of(1, StringUtils.substringBefore(signalMessage, COMMA)); } else { return ImmutableMap.of(1, signalMessage); } } }

  4. Assistant

    private Map<Integer, String> getLocatorCode(String signalMessage) { Map<Integer, String> locatorCode = new HashMap<>();

    int commaIndex = signalMessage.indexOf(COMMA);
    int verticalIndex = signalMessage.indexOf(VERTICAL);
    
    if (verticalIndex != -1) {
        if (commaIndex != -1) {
            locatorCode.put(1, signalMessage.substring(0, commaIndex));
            locatorCode.put(2, signalMessage.substring(verticalIndex + 1, commaIndex));
        } else {
            locatorCode.put(1, signalMessage.substring(0, verticalIndex));
            locatorCode.put(2, signalMessage.substring(verticalIndex + 1));
        }
    } else {
        if (commaIndex != -1) {
            locatorCode.put(1, signalMessage.substring(0, commaIndex));
        } else {
            locatorCode.put(1, signalMessage);
        }
    }
    
    return Collections.unmodifiableMap(locatorCode);
    

    }