尝试优化以下代码效率:private Map<String, Date> reckonGmtScanTime( List<PackingInfo>…
- User
尝试优化以下代码效率:private Map<String, Date> reckonGmtScanTime( List packingOrbitList, Date eScanDate, Date bScanDate, PalletConfig.Orbit orbit) { //如果最后一箱的team为空 int flag; Date bGmtScan = bScanDate; Date eGmtScan = eScanDate; Map<String, Date> map = new HashMap<>(4); if (bScanDate == null) { flag = 1; Date gmtConfirm = packingOrbitList.get(0).getGmtConfirm(); PackingInfo bPackingInfo = packingInfoMapper.selectOneByPackingOrbitGmtScan( this.config.getProductLineId(), this.config.getProductId(), gmtConfirm, orbit.getIndex(), flag); if (bPackingInfo != null) { bGmtScan = getTimes(bPackingInfo, gmtConfirm); } map.put("bScanDate", bGmtScan); } else { map.put("bScanDate", bGmtScan); } if (eScanDate == null) { flag = 2; Date gmtConfirm = packingOrbitList.get(packingOrbitList.size() - 1).getGmtConfirm(); PackingInfo ePackingInfo = packingInfoMapper.selectOneByPackingOrbitGmtScan(this.config.getProductLineId(), this.config.getProductId(), gmtConfirm, orbit.getIndex(), flag); if (ePackingInfo != null) { eGmtScan = getTimes(ePackingInfo, gmtConfirm); } map.put("eScanDate", eGmtScan); } else { map.put("eScanDate", eGmtScan); } return map; }
- Assistant
首先,可以对代码进行简化和重构:
- 去除冗余的if-else语句,直接在最后一行代码中进行赋值。
- 合并变量的声明和赋值,避免使用额外的变量。
优化后的代码如下:
private Map<String, Date> reckonGmtScanTime( List packingOrbitList, Date eScanDate, Date bScanDate, PalletConfig.Orbit orbit) { int flag; Date bGmtScan = bScanDate != null ? bScanDate : null; Date eGmtScan = eScanDate != null ? eScanDate : null; Map<String, Date> map = new HashMap<>(4);
if (bScanDate == null) { flag = 1; Date gmtConfirm = packingOrbitList.get(0).getGmtConfirm(); PackingInfo bPackingInfo = packingInfoMapper.selectOneByPackingOrbitGmtScan( this.config.getProductLineId(), this.config.getProductId(), gmtConfirm, orbit.getIndex(), flag); if (bPackingInfo != null) { bGmtScan = getTimes(bPackingInfo, gmtConfirm); } } map.put("bScanDate", bGmtScan); if (eScanDate == null) { flag = 2; Date gmtConfirm = packingOrbitList.get(packingOrbitList.size() - 1).getGmtConfirm(); PackingInfo ePackingInfo = packingInfoMapper.selectOneByPackingOrbitGmtScan( this.config.getProductLineId(), this.config.getProductId(), gmtConfirm, orbit.getIndex(), flag); if (ePackingInfo != null) { eGmtScan = getTimes(ePackingInfo, gmtConfirm); } } map.put("eScanDate", eGmtScan); return map;}