in dao.js exports.publishedPageContent = (pageid) => { return new Promise((resolve,…
- User
in dao.js exports.publishedPageContent = (pageid) => { return new Promise((resolve, reject) => { const sql =
SELECT pages.title AS title, pages.authorId AS authorId, users.name AS authorName, pages.creationDate AS creationDate, pages.publishDate AS publishDate, pages.blocks AS blocks FROM pages JOIN users ON pages.authorId = users.id WHERE pages.id=?; db.get(sql, [pageid], (err, row) => { //db.get returns only the first element matching the query if (err) { reject(err); return; } if (row == undefined) { resolve({ error404: "Page not found." }); //Page not found } else if (dayjs(row.publishDate).isAfter(dayjs()) || !dayjs(row.publishDate).isValid()) { //draft or programmed - dayjs() returns today date resolve({ error403: "Forbidden. FrontOffice-view is unable to access a non-published page. Login to unlock this limitation." }); } else { const info = { title: row.title, authorName: row.authorName, creationDate: row.creationDate, publishDate: row.publishDate, blocks: row.blocks }; resolve(info); } }); }); };in server.js app.get('/api/view/:pageid', async (req, res) => { try { // If request from auth-user we call pageContent otherwise we call publishedPageContent. Doing this we anable the view of non-published pages to loggedin users. const result = await dao.publishedPageContent(req.params.pageid); if (result.error401) res.status(401).json(result); else if (result.error403) res.status(403).json(result); else if (result.error404) res.status(404).json(result); else res.json(result); } catch (err) { res.status(500).end(); } });
how can I create better error managment?
- Assistant
You can create custom error classes extending the built-in Error class to handle different types of errors. Then, use these custom error classes in the dao.js and server.js files to provide better error management. Here is an example:
- Create custom error classes in a separate file, e.g., errors.js:
class CustomError extends Error { constructor(message, status) { super(message); this.status = status; } } class NotFoundError extends CustomError { constructor(message = "Page not found.") { super(message, 404); } } class ForbiddenError extends CustomError { constructor(message = "Forbidden access.") { super(message, 403); } } module.exports = { NotFoundError, ForbiddenError };- Modify dao.js to use custom error classes:
const { NotFoundError, ForbiddenError } = require("./errors"); // ... exports.publishedPageContent = (pageid) => { return new Promise((resolve, reject) => { // ... if (row == undefined) { reject(new NotFoundError()); } else if ( dayjs(row.publishDate).isAfter(dayjs()) || !dayjs(row.publishDate).isValid() ) { reject(new ForbiddenError("Forbidden. FrontOffice-view is ...")); } else { const info = { ... }; resolve(info); } }); };- Modify server.js to handle custom error classes:
const { NotFoundError, ForbiddenError } = require("./errors"); // ... app.get("/api/view/:pageid", async (req, res) => { try { const result = await dao.publishedPageContent(req.params.pageid); res.json(result); } catch (err) { if (err instanceof NotFoundError || err instanceof ForbiddenError) { res.status(err.status).json({ error: err.message }); } else { console.error(err); res.status(500).end(); } } });Now you are using custom error classes to handle specific error types in a more organized way. This makes maintaining and extending your error management easier. Consider adding more custom error classes as needed.
Other models, same or similar prompt
Responses were produced in different, uncontrolled contexts (system prompts, settings, prior turns). This is not a benchmark.